Review Request 118310: support for graphic properties of Geogebra objects in KIG

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118310/#review72226
-----------------------------------------------------------



geogebra/geogebra.xsl
<https://git.reviewboard.kde.org/r/118310/#comment50378>

    Could you put this (and the code that handle these vars) in a separate patch up for review? Looks unrelated to the rest of the properties in the sense that these are for the whole drawing



geogebra/geogebratransformer.h
<https://git.reviewboard.kde.org/r/118310/#comment50379>

    space above the comment



geogebra/geogebratransformer.h
<https://git.reviewboard.kde.org/r/118310/#comment50380>

    space above the comment


Pretty much done, just a couple of comments and the split of the grid/axis part

- David Narváez


On Dec. 6, 2014, 9:40 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118310/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2014, 9:40 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables KIG to read the graphic properties of Geogebra objects from Geogebra worksheets.
> Here is some explanation about my implementation:
>   
> the graphic properties ( lineStyle, pointStyle, lineWidth, color ) are read for each geogebra object. I add an attribute for each property to each of the intermediate representation of each of the objects created using XSLT. Some variables are added to the KigFilterGeogebra class to hold the values of the properties for each of the objects. In the attribute() callback method of the KigFilterGeogebra class , the values of the properties are read ( and suitably mapped to KIG's ) and when the endElement() callback is called a new ObjectDrawer with the last read properties is allocated for this object.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.cpp cff342d 
>   geogebra/geogebra.xsl c1e4749 
>   geogebra/geogebrasection.h aed7dcb 
>   geogebra/geogebrasection.cpp e9778ed 
>   geogebra/geogebratransformer.h 5f36827 
>   geogebra/geogebratransformer.cpp aee8669 
> 
> Diff: https://git.reviewboard.kde.org/r/118310/diff/
> 
> 
> Testing
> -------
> 
> Tested! some trouble in the mapping of PointStyles.
> 
> 
> File Attachments
> ----------------
> 
> Test file
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/15/9799362b-472e-4814-9d78-da2bf07d612c__gui.ggb
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141218/75b4d0fe/attachment-0001.html>