Review Request 118310: support for graphic properties of Geogebra objects in KIG

[Aniket Anvit]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118310/
-----------------------------------------------------------

(Updated Dec. 6, 2014, 3:10 p.m.)


Review request for KDE Edu and David Narváez.


Changes
-------

All issues resolved except that the Hollow-Circle and Hollow-Rectangle points are not drawing in Kig.


Repository: kig


Description
-------

This patch enables KIG to read the graphic properties of Geogebra objects from Geogebra worksheets.
Here is some explanation about my implementation:
  
the graphic properties ( lineStyle, pointStyle, lineWidth, color ) are read for each geogebra object. I add an attribute for each property to each of the intermediate representation of each of the objects created using XSLT. Some variables are added to the KigFilterGeogebra class to hold the values of the properties for each of the objects. In the attribute() callback method of the KigFilterGeogebra class , the values of the properties are read ( and suitably mapped to KIG's ) and when the endElement() callback is called a new ObjectDrawer with the last read properties is allocated for this object.


Diffs (updated)
-----

  filters/geogebra-filter.cpp cff342d 
  geogebra/geogebra.xsl c1e4749 
  geogebra/geogebrasection.h aed7dcb 
  geogebra/geogebrasection.cpp e9778ed 
  geogebra/geogebratransformer.h 5f36827 
  geogebra/geogebratransformer.cpp aee8669 

Diff: https://git.reviewboard.kde.org/r/118310/diff/


Testing
-------

Tested! some trouble in the mapping of PointStyles.


File Attachments
----------------

Test file
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/15/9799362b-472e-4814-9d78-da2bf07d612c__gui.ggb


Thanks,

Aniket Anvit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141206/3105c38d/attachment.html>