Review Request 121566: Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.

Jeremy Whiting jpwhiting at kde.org
Wed Dec 17 15:37:47 UTC 2014


Fixed in git. If we do in fact need the setCategoryName for something, we
can re add it in the proper way that doesn't break the kpart.

On Wed, Dec 17, 2014 at 7:34 AM, Christoph Feck <christoph at maxiom.de> wrote:
>
>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121566/
>
> The patch which is attached here works, but the commit was a bit different. Now kmplot lacks its kpart menus and toolbars.
>
>
> - Christoph Feck
>
> On December 17th, 2014, 2:43 a.m. UTC, Jeremy Whiting wrote:
>   Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> By Jeremy Whiting.
>
> *Updated Dec. 17, 2014, 2:43 a.m.*
>  *Repository: * kmplot
> Description
>
> Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.
>
>   Testing
>
> It builds, runs and shows the kmplot ui where before this it doesn't.
>
> One remaining question is the setComponentData call, Running kmplot with these changes the help->about kmplot works fine and such, so I'm not sure what that call is even for tbh.
>
>   Diffs
>
>    - kmplot/kmplot.cpp (9a6fe88b64a708b3ed2918779563ea79f58ec4c1)
>    - kmplot/maindlg.h (022bd02ec4b49be987950a09507402c4facec080)
>    - kmplot/maindlg.cpp (ef36cf2247b5301b44a5f5b4992c407dbb0b8549)
>
> View Diff <https://git.reviewboard.kde.org/r/121566/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141217/3ab8cf11/attachment-0001.html>


More information about the kde-edu mailing list