Review Request 121566: Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.

[Aleix Pol Gonzalez]

> On Dec. 16, 2014, 9:59 p.m., Inge Wallin wrote:
> > kmplot/maindlg.cpp, line 146
> > <https://git.reviewboard.kde.org/r/121566/diff/1/?file=333548#file333548line146>
> >
> >     I don't understand this.  Should it go or should it stay?

You want to use setComponentName now, and just use the same it's used in the K_PLUGIN_FACTORY.


> On Dec. 16, 2014, 9:59 p.m., Inge Wallin wrote:
> > kmplot/maindlg.cpp, line 868
> > <https://git.reviewboard.kde.org/r/121566/diff/1/?file=333548#file333548line868>
> >
> >     Do you really need this when you have automoc?

Yes, if you define a Q_OBJECT in the .cpp file, which is the case because the macro expands into a Q_OBJECT declaration.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121566/#review72142
-----------------------------------------------------------


On Dec. 16, 2014, 9:51 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121566/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 9:51 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: kmplot
> 
> 
> Description
> -------
> 
> Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.
> 
> 
> Diffs
> -----
> 
>   kmplot/kmplot.cpp 9a6fe88b64a708b3ed2918779563ea79f58ec4c1 
>   kmplot/maindlg.h 022bd02ec4b49be987950a09507402c4facec080 
>   kmplot/maindlg.cpp ef36cf2247b5301b44a5f5b4992c407dbb0b8549 
> 
> Diff: https://git.reviewboard.kde.org/r/121566/diff/
> 
> 
> Testing
> -------
> 
> It builds, runs and shows the kmplot ui where before this it doesn't.
> 
> One remaining question is the setComponentData call, Running kmplot with these changes the help->about kmplot works fine and such, so I'm not sure what that call is even for tbh.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141216/87ada46c/attachment.html>