Review Request 121566: Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121566/#review72142
-----------------------------------------------------------


Looks good in general but I can't give you a ship it! because I don't understand this code well enough. See a few comments below.


kmplot/maindlg.cpp
<https://git.reviewboard.kde.org/r/121566/#comment50321>

    I don't understand this.  Should it go or should it stay?



kmplot/maindlg.cpp
<https://git.reviewboard.kde.org/r/121566/#comment50322>

    Do you really need this when you have automoc?


- Inge Wallin


On Dec. 16, 2014, 9:51 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121566/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 9:51 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Inge Wallin.
> 
> 
> Repository: kmplot
> 
> 
> Description
> -------
> 
> Fix KMPlot running by changing it to a K_PLUGIN_FACTORY and fixing the name we look it up with.
> 
> 
> Diffs
> -----
> 
>   kmplot/kmplot.cpp 9a6fe88b64a708b3ed2918779563ea79f58ec4c1 
>   kmplot/maindlg.h 022bd02ec4b49be987950a09507402c4facec080 
>   kmplot/maindlg.cpp ef36cf2247b5301b44a5f5b4992c407dbb0b8549 
> 
> Diff: https://git.reviewboard.kde.org/r/121566/diff/
> 
> 
> Testing
> -------
> 
> It builds, runs and shows the kmplot ui where before this it doesn't.
> 
> One remaining question is the setComponentData call, Running kmplot with these changes the help->about kmplot works fine and such, so I'm not sure what that call is even for tbh.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141216/7dbe18c0/attachment.html>