Review Request 121558: Port from KStandardDirs to QStandardPaths

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121558/#review72128
-----------------------------------------------------------


Looks good from what I could see.  Please fix the minor issue that I pointed out below and then let's see what Jeremy says about the GHNS issue.


step/mainwindow.cc
<https://git.reviewboard.kde.org/r/121558/#comment50313>

    +"" seems to be an unnecessary thing...


- Inge Wallin


On Dec. 16, 2014, 4:18 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121558/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 4:18 p.m.)
> 
> 
> Review request for KDE Edu, Inge Wallin and Jeremy Whiting.
> 
> 
> Repository: step
> 
> 
> Description
> -------
> 
> With KStandardDirs becoming deprecated, the code was ported to QStandardPaths.
> 
> 
> Diffs
> -----
> 
>   step/infobrowser.cc 03602db 
>   step/latexformula.cc 617a5c3 
>   step/mainwindow.cc 13073b6 
> 
> Diff: https://git.reviewboard.kde.org/r/121558/diff/
> 
> 
> Testing
> -------
> 
> After the porting the following has been tested with successful results-
>   * Load the given examples
>   * Simulate the tutorials
>   * Create your own experiments, save them, and later load them
> 
> The following is still not working and needs more work-
>   * Downloading stuff using GHNS
> 
> GHNS is not working because it can't locate the step.knsrc file
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141216/a2dc6976/attachment.html>