Review Request 121558: Port from KStandardDirs to QStandardPaths
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Dec 16 16:57:18 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121558/#review72127
-----------------------------------------------------------
step/mainwindow.cc
<https://git.reviewboard.kde.org/r/121558/#comment50308>
If you want a directory, you must pass an aditional QStandardPaths::LocateDirectory
step/mainwindow.cc
<https://git.reviewboard.kde.org/r/121558/#comment50309>
why +""?
step/mainwindow.cc
<https://git.reviewboard.kde.org/r/121558/#comment50310>
LocateDirectory
step/mainwindow.cc
<https://git.reviewboard.kde.org/r/121558/#comment50311>
Remove the +"".
step/mainwindow.cc
<https://git.reviewboard.kde.org/r/121558/#comment50312>
make it +"/examples"
- Aleix Pol Gonzalez
On Dec. 16, 2014, 4:18 p.m., Rahul Chowdhury wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121558/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 4:18 p.m.)
>
>
> Review request for KDE Edu, Inge Wallin and Jeremy Whiting.
>
>
> Repository: step
>
>
> Description
> -------
>
> With KStandardDirs becoming deprecated, the code was ported to QStandardPaths.
>
>
> Diffs
> -----
>
> step/infobrowser.cc 03602db
> step/latexformula.cc 617a5c3
> step/mainwindow.cc 13073b6
>
> Diff: https://git.reviewboard.kde.org/r/121558/diff/
>
>
> Testing
> -------
>
> After the porting the following has been tested with successful results-
> * Load the given examples
> * Simulate the tutorials
> * Create your own experiments, save them, and later load them
>
> The following is still not working and needs more work-
> * Downloading stuff using GHNS
>
> GHNS is not working because it can't locate the step.knsrc file
>
>
> Thanks,
>
> Rahul Chowdhury
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141216/375a9946/attachment-0001.html>
More information about the kde-edu
mailing list