Review Request 121374: Cantor Python2 to Python3 backend porting for KF5

[Pino Toscano]

> On Dic. 14, 2014, 12:34 p.m., Pino Toscano wrote:
> > src/backends/CMakeLists.txt, line 50
> > <https://git.reviewboard.kde.org/r/121374/diff/3/?file=333107#file333107line50>
> >
> >     Why isn't this using cmake's FindPythonLibs.cmake module, and instead you rewrote a tiny bit of it on your own?
> 
> Minh Ngo wrote:
>     it has a known bug http://www.cmake.org/Bug/print_bug_page.php?bug_id=13794

That bug seems to have been solved in recent cmake versions, did you check that?

FindPythonLibs.cmake has quite some logic to deal with different ABIs of libpython, different versions, multiple include directories, and so on. All of them are lost in your pretty simple reimplementation, while they are needed (and there are reasons for them).


- Pino


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121374/#review71974
-----------------------------------------------------------


On Dic. 14, 2014, 1:38 p.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121374/
> -----------------------------------------------------------
> 
> (Updated Dic. 14, 2014, 1:38 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Have meda some fixes in cmake files to find python3 correctly...
> 
> 
> Diffs
> -----
> 
>   cmake/FindPythonLibs3.cmake PRE-CREATION 
>   src/backends/CMakeLists.txt e27c84d 
>   src/backends/R/cantor_r.knsrc 02f9a1e 
>   src/backends/kalgebra/cantor_kalgebra.knsrc d0103eb 
>   src/backends/lua/cantor_lua.knsrc 25165d0 
>   src/backends/maxima/cantor_maxima.knsrc 7cccce8 
>   src/backends/octave/cantor_octave.knsrc 735739a 
>   src/backends/python/pythonbackend.cpp 3f66f39 
>   src/backends/python/pythonexpression.cpp 883c3ea 
>   src/backends/python/pythonsession.cpp c252572 
>   src/backends/python/pythonutils.h PRE-CREATION 
>   src/backends/python2/CMakeLists.txt 260c2f0 
>   src/backends/python2/cantor_python2.knsrc 7ec699c 
>   src/backends/python3/CMakeLists.txt PRE-CREATION 
>   src/backends/python3/cantor_python3.knsrc PRE-CREATION 
>   src/backends/python3/python3backend.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121374/diff/
> 
> 
> Testing
> -------
> 
> 1)
> a = 1
> b = 2
> print(a + b)
> 
> 2)
> import numpy as np
> a = np.array([1, 2, 3])
> print(a)
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20141214/571e171e/attachment.html>