<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121374/">https://git.reviewboard.kde.org/r/121374/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On dicembre 14th, 2014, 12:34 p.m. UTC, <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121374/diff/3/?file=333107#file333107line50" style="color: black; font-weight: bold; text-decoration: underline;">src/backends/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">set_package_properties</span><span class="p">(</span><span class="s">PythonLibs3</span> <span class="s">PROPERTIES</span> <span class="s">DESCRIPTION</span> <span class="s2">"A powerful dynamic programming language."</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why isn't this using cmake's FindPythonLibs.cmake module, and instead you rewrote a tiny bit of it on your own?</p></pre>
</blockquote>
<p>On dicembre 14th, 2014, 1:06 p.m. UTC, <b>Minh Ngo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it has a known bug http://www.cmake.org/Bug/print_bug_page.php?bug_id=13794</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That bug seems to have been solved in recent cmake versions, did you check that?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FindPythonLibs.cmake has quite some logic to deal with different ABIs of libpython, different versions, multiple include directories, and so on. All of them are lost in your pretty simple reimplementation, while they are needed (and there are reasons for them).</p></pre>
<br />
<p>- Pino</p>
<br />
<p>On dicembre 14th, 2014, 1:38 p.m. UTC, Minh Ngo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Minh Ngo.</div>
<p style="color: grey;"><i>Updated Dic. 14, 2014, 1:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have meda some fixes in cmake files to find python3 correctly...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1)
a = 1
b = 2
print(a + b)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2)
import numpy as np
a = np.array([1, 2, 3])
print(a)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindPythonLibs3.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(e27c84d)</span></li>
<li>src/backends/R/cantor_r.knsrc <span style="color: grey">(02f9a1e)</span></li>
<li>src/backends/kalgebra/cantor_kalgebra.knsrc <span style="color: grey">(d0103eb)</span></li>
<li>src/backends/lua/cantor_lua.knsrc <span style="color: grey">(25165d0)</span></li>
<li>src/backends/maxima/cantor_maxima.knsrc <span style="color: grey">(7cccce8)</span></li>
<li>src/backends/octave/cantor_octave.knsrc <span style="color: grey">(735739a)</span></li>
<li>src/backends/python/pythonbackend.cpp <span style="color: grey">(3f66f39)</span></li>
<li>src/backends/python/pythonexpression.cpp <span style="color: grey">(883c3ea)</span></li>
<li>src/backends/python/pythonsession.cpp <span style="color: grey">(c252572)</span></li>
<li>src/backends/python/pythonutils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python2/CMakeLists.txt <span style="color: grey">(260c2f0)</span></li>
<li>src/backends/python2/cantor_python2.knsrc <span style="color: grey">(7ec699c)</span></li>
<li>src/backends/python3/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/cantor_python3.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/python3backend.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121374/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>