Review Request 113096: No artifacts when the scrollbars are shown and used to jump to the right or bottom.

Albert Astals Cid aacid at kde.org
Sun Oct 13 22:04:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113096/#review41668
-----------------------------------------------------------


Looks good, since it's a bit of a "big change" maybe it's better if you only commit to master just in case something breaks. What do you think?


src/mapwidget.h
<http://git.reviewboard.kde.org/r/113096/#comment30448>

    Remove this


- Albert Astals Cid


On Oct. 10, 2013, 11:32 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113096/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 11:32 a.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Just paint the background white and then draw the image.
> 
> 
> Diffs
> -----
> 
>   src/mapwidget.h 1211d2c 
>   src/mapwidget.cpp 57ab716 
> 
> Diff: http://git.reviewboard.kde.org/r/113096/diff/
> 
> 
> Testing
> -------
> 
> Before: In big maps like Portugal, when the scrollbars appear, and you click in the right part of the scrollbar (or the lowest for vertical), to jump to the lower right corner, you could see rendering artifacts.
> Now: No artifacts, just white.
> 
> 
> File Attachments
> ----------------
> 
> screen capture
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/08/50cc156b-25d1-4c08-859c-534a9dfaf702__kgeography_problem.png
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131013/2ab7c7a3/attachment.html>


More information about the kde-edu mailing list