Review Request 113096: No artifacts when the scrollbars are shown and used to jump to the right or bottom.

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113096/
-----------------------------------------------------------

(Updated Oct. 10, 2013, 11:32 a.m.)


Review request for KDE Edu and Albert Astals Cid.


Changes
-------

The problem with the space at the right and bottom of the image seems to be in QGraphicsView.
When a verticalScrollBar is used, around 6 horizontal pixels are automatically added to the scene. (similar case with the horizontalScrollBar)
If I load an image smaller than the screen size, no problem, no scrollbars. When I resize the program only horizontally, (no vertical scrollbar), no white space is added. If a vertical scrollbar appears, here is the white space. (with version 1 or 2 of the patch)
There is nothing I can see to avoid this. I tried to resize the scene based on the presence of scrollbars, and created an infinite loop.


Version 2 of the patch:
Instead of paint the background, add the image (converted to pixmap) to the scene and let Qt draw it.
(before commiting, the commented drawBackground will dissapear, also the red spaces)


Repository: kgeography


Description
-------

Just paint the background white and then draw the image.


Diffs (updated)
-----

  src/mapwidget.h 1211d2c 
  src/mapwidget.cpp 57ab716 

Diff: http://git.reviewboard.kde.org/r/113096/diff/


Testing
-------

Before: In big maps like Portugal, when the scrollbars appear, and you click in the right part of the scrollbar (or the lowest for vertical), to jump to the lower right corner, you could see rendering artifacts.
Now: No artifacts, just white.


File Attachments
----------------

screen capture
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/08/50cc156b-25d1-4c08-859c-534a9dfaf702__kgeography_problem.png


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131010/bd8de832/attachment.html>