Review Request 111472: Used KIO for opening and saving a file in Khipu

[Punit Mehta]

> On July 11, 2013, 3:31 p.m., Aleix Pol Gonzalez wrote:
> > src/mainwindow.h, line 60
> > <http://git.reviewboard.kde.org/r/111472/diff/2/?file=170108#file170108line60>
> >
> >     why does it return bool but then you never read the returned value?

I have used the return value in main.cpp to open a .khipu file from command-line.


> On July 11, 2013, 3:31 p.m., Aleix Pol Gonzalez wrote:
> > src/mainwindow.h, line 115
> > <http://git.reviewboard.kde.org/r/111472/diff/2/?file=170108#file170108line115>
> >
> >     same

I haven't used it yet. but I feel it might be useful later on.


- Punit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111472/#review35864
-----------------------------------------------------------


On July 10, 2013, 11:27 a.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111472/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 11:27 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> Used KIO for saving and opening a file in khipu. I have already reviewed this diff with Antonio. But still , I think it is better to publish it once !
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 027da30 
>   src/mainwindow.h 137e82c 
>   src/mainwindow.cpp 67d8c72 
> 
> Diff: http://git.reviewboard.kde.org/r/111472/diff/
> 
> 
> Testing
> -------
> 
> done ! worked perfectly ! 
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130712/9ce5e556/attachment.html>