Review Request 111472: Used KIO for opening and saving a file in Khipu

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111472/#review35864
-----------------------------------------------------------



src/mainwindow.h
<http://git.reviewboard.kde.org/r/111472/#comment26557>

    why does it return bool but then you never read the returned value?



src/mainwindow.h
<http://git.reviewboard.kde.org/r/111472/#comment26558>

    same



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26561>

    the else goes at the same line as the closing brace.
    
    if() {
    ...
    } else {
    ..
    }



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26562>

    cache toLocalFile?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26563>

    ?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/111472/#comment26564>

    append?
    
    no, use i18n("File: %1 [%2]", x, y);


- Aleix Pol Gonzalez


On July 10, 2013, 11:27 a.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111472/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 11:27 a.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> Used KIO for saving and opening a file in khipu. I have already reviewed this diff with Antonio. But still , I think it is better to publish it once !
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 027da30 
>   src/mainwindow.h 137e82c 
>   src/mainwindow.cpp 67d8c72 
> 
> Diff: http://git.reviewboard.kde.org/r/111472/diff/
> 
> 
> Testing
> -------
> 
> done ! worked perfectly ! 
> 
> 
> Thanks,
> 
> Punit Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130711/ef5f9d48/attachment.html>