Review Request: Fixing Krazy Code Checker Issues

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108167/#review24688
-----------------------------------------------------------



src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18934>

    No. this is a false positive.
    line is a QByteArray, so its overload for const char* is applicable and doesn't lead to a non-trivial conversion



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18935>

    QLatin1String must end with the string literal, here "%day_f"
    "%" should be '%' or QLatin1Char('%')



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18936>

    see above



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18937>

    see above



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18938>

    see above



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18939>

    see above



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18940>

    see above



src/plugins/render/weather/WeatherItem.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18941>

    see above



src/plugins/runner/local-osm-search/OsmDatabase.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18942>

    this doesn't work, unfortunately
    correct solution is to make "m" into
    QLatin1String( "m" );



src/plugins/runner/local-osm-search/OsmDatabase.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18943>

    ''' will not compile due to the second ' ending the quote
    '\'' should work



src/plugins/runner/local-osm-search/OsmDatabase.cpp
<http://git.reviewboard.kde.org/r/108167/#comment18944>

    same here


- Kevin Krammer


On Jan. 4, 2013, 5:56 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108167/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 5:56 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Mainly fixed single-char QString operations for efficiency
> 
> 
> Diffs
> -----
> 
>   src/ControlView.cpp a12f80f 
>   src/lib/MarbleWidgetPopupMenu.cpp 1df71fb 
>   src/lib/VectorTileMapper.cpp fd7d282 
>   src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp 1c9fe08 
>   src/lib/kdescendantsproxymodel.cpp 708475e 
>   src/lib/routing/RoutingManager.cpp c4cc226 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp 9865342 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp 49f93da 
>   src/plugins/render/weather/WeatherItem.cpp 52e1582 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp d9ffe21 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp 492d730 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp a4f255c 
>   tests/BookmarkManagerTest.cpp b821d75 
>   tools/shp2pn2/shp2pn2.cpp ca0894e 
>   tools/speaker-files/main.cpp de7688b 
> 
> Diff: http://git.reviewboard.kde.org/r/108167/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130104/06fa990c/attachment-0001.html>