<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108167/">http://git.reviewboard.kde.org/r/108167/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104692#file104692line92" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FlightGearPositionProviderPlugin::initialize()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">line</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="s">"$GPRMC"</span><span class="p">))</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">line</span><span class="p">.</span><span class="n">startsWith</span><span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="s">"$GPRMC"</span><span class="p">))<span class="hl">)</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No. this is a false positive.
line is a QByteArray, so its overload for const char* is applicable and doesn't lead to a non-trivial conversion</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line536" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">536</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%day_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span> <span class="n">locale</span><span class="p">.</span><span class="n">standaloneDayName</span><span class="p">(</span><span class="n">date</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">536</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n"><span class="hl">QLatin1String</span></span><span class="p"><span class="hl">(</span></span><span class="s">"%day_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span> <span class="n">locale</span><span class="p">.</span><span class="n">standaloneDayName</span><span class="p">(</span><span class="n">date</span><span class="p">.</span><span class="n">dayOfWeek</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QLatin1String must end with the string literal, here "%day_f"
"%" should be '%' or QLatin1Char('%')</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line537" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">537</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%weather_situation_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span> <span class="s">"file://"</span><span class="o">+</span><span class="n">forecast</span><span class="p">.</span><span class="n">iconSource</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">537</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"%weather_situation_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span> <span class="s">"file://"</span><span class="o">+</span><span class="n">forecast</span><span class="p">.</span><span class="n">iconSource</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line539" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">539</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%max_temp_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">539</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"%max_temp_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line543" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">543</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%condition_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">conditionString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">543</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"%condition_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">conditionString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line544" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">544</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%wind_direction_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">windDirectionString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">544</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"%wind_direction_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">windDirectionString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line545" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">545</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%wind_speed_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">windSpeedString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">545</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"%wind_speed_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">windSpeedString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104694#file104694line546" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/weather/WeatherItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString WeatherItem::createFromTemplate(const QString &templateHtml)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">546</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="s">"%publish_time_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p">,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">publishingTime</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">546</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="p">.</span><span class="n">replace</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"%publish_time_f"</span><span class="o">+</span><span class="n">suffix</span><span class="o">+</span><span class="s">"%"</span><span class="p"><span class="hl">)</span>,</span> <span class="n">forecast</span><span class="p">.</span><span class="n">publishingTime</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see above</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104697#file104697line213" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/local-osm-search/OsmDatabase.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void OsmDatabase::unique( QVector<OsmPlacemark> &placemarks ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">213</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">distanceUnit</span> <span class="o">=</span> <span class="s"><span class="hl">"m"</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">213</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">distanceUnit</span> <span class="o">=</span> <span class="sc"><span class="hl">'m'</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this doesn't work, unfortunately
correct solution is to make "m" into
QLatin1String( "m" );</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104697#file104697line273" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/local-osm-search/OsmDatabase.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">qreal OsmDatabase::bearing( const GeoDataCoordinates &a, const GeoDataCoordinates &b ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">273</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">" LIKE '"</span> <span class="o">+</span> <span class="n">result</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span> <span class="sc">'*'</span><span class="p">,</span> <span class="sc">'%'</span> <span class="p">)</span> <span class="o">+</span> <span class="s"><span class="hl">"'"</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">273</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">" LIKE '"</span> <span class="o">+</span> <span class="n">result</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span> <span class="sc">'*'</span><span class="p">,</span> <span class="sc">'%'</span> <span class="p">)</span> <span class="o">+</span> <span class="err"><span class="hl">'''</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">''' will not compile due to the second ' ending the quote
'\'' should work</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108167/diff/1/?file=104697#file104697line275" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/local-osm-search/OsmDatabase.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">qreal OsmDatabase::bearing( const GeoDataCoordinates &a, const GeoDataCoordinates &b ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">275</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">" = '"</span> <span class="o">+</span> <span class="n">result</span> <span class="o">+</span> <span class="s"><span class="hl">"'"</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">275</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">" = '"</span> <span class="o">+</span> <span class="n">result</span> <span class="o">+</span> <span class="err"><span class="hl">'''</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same here</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On January 4th, 2013, 5:56 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 5:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mainly fixed single-char QString operations for efficiency</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ControlView.cpp <span style="color: grey">(a12f80f)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(1df71fb)</span></li>
<li>src/lib/VectorTileMapper.cpp <span style="color: grey">(fd7d282)</span></li>
<li>src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp <span style="color: grey">(1c9fe08)</span></li>
<li>src/lib/kdescendantsproxymodel.cpp <span style="color: grey">(708475e)</span></li>
<li>src/lib/routing/RoutingManager.cpp <span style="color: grey">(c4cc226)</span></li>
<li>src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp <span style="color: grey">(9865342)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.cpp <span style="color: grey">(49f93da)</span></li>
<li>src/plugins/render/weather/WeatherItem.cpp <span style="color: grey">(52e1582)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp <span style="color: grey">(d9ffe21)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp <span style="color: grey">(492d730)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.cpp <span style="color: grey">(a4f255c)</span></li>
<li>tests/BookmarkManagerTest.cpp <span style="color: grey">(b821d75)</span></li>
<li>tools/shp2pn2/shp2pn2.cpp <span style="color: grey">(ca0894e)</span></li>
<li>tools/speaker-files/main.cpp <span style="color: grey">(de7688b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108167/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>