Review Request: Krazy fixes: mark single argument constructors as explicit #2

[Kevin Krammer]

> On Jan. 1, 2013, 9:51 p.m., Kevin Krammer wrote:
> > src/lib/StoragePolicy.h, line 30
> > <http://git.reviewboard.kde.org/r/108071/diff/1/?file=103674#file103674line30>
> >
> >     Maybe we can fix the intendation while we are changing this line, i.e. align the explicit with the virtual below

Ah, this is actually intendation by tab instead of spaces. will fix before committing


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108071/#review24388
-----------------------------------------------------------


On Jan. 1, 2013, 8:29 p.m., Kyle Morris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108071/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 8:29 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Add explicit keyword to constructors which could potentially lead to implicit type conversions
> 
> 
> Diffs
> -----
> 
>   src/lib/AbstractDataPlugin.h 37ab921 
>   src/lib/DownloadRegion.h bf6d67b 
>   src/lib/GeoGraphicsScene.h aa5baef 
>   src/lib/MarbleWidgetInputHandler.h 6c216fb 
>   src/lib/SearchInputWidget.h c2274e7 
>   src/lib/ServerLayout.h 63fbdb4 
>   src/lib/StoragePolicy.h 1647129 
>   src/lib/geodata/data/GeoDataAccuracy.h 6e7132c 
>   src/lib/geodata/data/GeoDataFeature.h a70e53d 
>   src/lib/geodata/data/GeoDataGeometry.h e5602ab 
>   src/lib/geodata/data/GeoDataLatLonAltBox.h bb68329 
>   src/lib/geodata/data/GeoDataLinearRing.h 9cfce6d 
>   src/lib/geodata/data/GeoDataPolygon.h 788f19e 
>   src/lib/geodata/data/GeoDataPolygon_p.h 46d3066 
>   src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.h 3b4bf7e 
>   src/lib/geodata/graphicsitem/GeoPolygonGraphicsItem.h 3b26f0e 
>   src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.h c320a78 
>   src/lib/geodata/graphicsitem/ScreenOverlayGraphicsItem.h 7cfdaac 
>   src/lib/geodata/scene/GeoSceneGeodata.h 9468061 
>   src/lib/geodata/writers/kml/KmlColorStyleTagWriter.h e9ac41c 
>   src/lib/geodata/writers/kml/KmlOverlayTagWriter.h e6332f2 
>   src/lib/graphicsview/FrameGraphicsItem_p.h 48a0524 
>   src/lib/graphicsview/LabelGraphicsItem_p.h feae56b 
>   src/lib/layers/GeometryLayer.h f89870e 
>   src/lib/layers/VectorMapBaseLayer.h 7db584e 
>   src/plugins/declarative/MapThemeModel.h e15e67e 
>   src/plugins/declarative/MarbleDeclarativeObject.h 721eb6c 
> 
> Diff: http://git.reviewboard.kde.org/r/108071/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kyle Morris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130101/d9cc9d3d/attachment-0001.html>