<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108071/">http://git.reviewboard.kde.org/r/108071/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 1st, 2013, 9:51 p.m., <b>Kevin Krammer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108071/diff/1/?file=103674#file103674line30" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/StoragePolicy.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Marble</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">StoragePolicy</span><span class="p">(</span> <span class="n">QObject</span> <span class="o">*</span><span class="n">parent</span> <span class="o">=</span> <span class="mi">0</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"><span class="tb"> </span></span><span class="n"><span class="hl">explicit</span></span><span class="hl"> </span><span class="n">StoragePolicy</span><span class="p">(</span> <span class="n">QObject</span> <span class="o">*</span><span class="n">parent</span> <span class="o">=</span> <span class="mi">0</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we can fix the intendation while we are changing this line, i.e. align the explicit with the virtual below</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, this is actually intendation by tab instead of spaces. will fix before committing</pre>
<br />
<p>- Kevin</p>
<br />
<p>On January 1st, 2013, 8:29 p.m., Kyle Morris wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Kyle Morris.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 8:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add explicit keyword to constructors which could potentially lead to implicit type conversions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractDataPlugin.h <span style="color: grey">(37ab921)</span></li>
<li>src/lib/DownloadRegion.h <span style="color: grey">(bf6d67b)</span></li>
<li>src/lib/GeoGraphicsScene.h <span style="color: grey">(aa5baef)</span></li>
<li>src/lib/MarbleWidgetInputHandler.h <span style="color: grey">(6c216fb)</span></li>
<li>src/lib/SearchInputWidget.h <span style="color: grey">(c2274e7)</span></li>
<li>src/lib/ServerLayout.h <span style="color: grey">(63fbdb4)</span></li>
<li>src/lib/StoragePolicy.h <span style="color: grey">(1647129)</span></li>
<li>src/lib/geodata/data/GeoDataAccuracy.h <span style="color: grey">(6e7132c)</span></li>
<li>src/lib/geodata/data/GeoDataFeature.h <span style="color: grey">(a70e53d)</span></li>
<li>src/lib/geodata/data/GeoDataGeometry.h <span style="color: grey">(e5602ab)</span></li>
<li>src/lib/geodata/data/GeoDataLatLonAltBox.h <span style="color: grey">(bb68329)</span></li>
<li>src/lib/geodata/data/GeoDataLinearRing.h <span style="color: grey">(9cfce6d)</span></li>
<li>src/lib/geodata/data/GeoDataPolygon.h <span style="color: grey">(788f19e)</span></li>
<li>src/lib/geodata/data/GeoDataPolygon_p.h <span style="color: grey">(46d3066)</span></li>
<li>src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.h <span style="color: grey">(3b4bf7e)</span></li>
<li>src/lib/geodata/graphicsitem/GeoPolygonGraphicsItem.h <span style="color: grey">(3b26f0e)</span></li>
<li>src/lib/geodata/graphicsitem/GeoTrackGraphicsItem.h <span style="color: grey">(c320a78)</span></li>
<li>src/lib/geodata/graphicsitem/ScreenOverlayGraphicsItem.h <span style="color: grey">(7cfdaac)</span></li>
<li>src/lib/geodata/scene/GeoSceneGeodata.h <span style="color: grey">(9468061)</span></li>
<li>src/lib/geodata/writers/kml/KmlColorStyleTagWriter.h <span style="color: grey">(e9ac41c)</span></li>
<li>src/lib/geodata/writers/kml/KmlOverlayTagWriter.h <span style="color: grey">(e6332f2)</span></li>
<li>src/lib/graphicsview/FrameGraphicsItem_p.h <span style="color: grey">(48a0524)</span></li>
<li>src/lib/graphicsview/LabelGraphicsItem_p.h <span style="color: grey">(feae56b)</span></li>
<li>src/lib/layers/GeometryLayer.h <span style="color: grey">(f89870e)</span></li>
<li>src/lib/layers/VectorMapBaseLayer.h <span style="color: grey">(7db584e)</span></li>
<li>src/plugins/declarative/MapThemeModel.h <span style="color: grey">(e15e67e)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeObject.h <span style="color: grey">(721eb6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108071/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>