Review Request 108917: Let GenericAffinityTransform and GenericProjectivityTransform use Repeated Points
Commit Hook
null at kde.org
Wed Feb 13 12:55:33 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108917/#review27358
-----------------------------------------------------------
This review has been submitted with commit 8026fc33a4b6a578954f18d10617b8ffe8601d58 by David E. Narváez to branch KDE/4.10.
- Commit Hook
On Feb. 12, 2013, 8:11 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108917/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2013, 8:11 a.m.)
>
>
> Review request for KDE Edu and Christoph Feck.
>
>
> Description
> -------
>
> This change is pretty trivial, but I'd like some BIC experts to check if I can commit this to 4.10. This is a year-old bug that was quite trivial to solve and I just realized that, so I wouldn't want users to wait for another major release for a fix.
>
>
> This addresses bug 294655.
> http://bugs.kde.org/show_bug.cgi?id=294655
>
>
> Diffs
> -----
>
> misc/object_constructor.h fbd019c
> misc/special_constructors.h d60d3d7
> misc/special_constructors.cc 94f7d50
>
> Diff: http://git.reviewboard.kde.org/r/108917/diff/
>
>
> Testing
> -------
>
> 1. Create 4 points
> 2. Create a line
> 3. Create a generic affinity transform that uses 3 of the 4 points as source vertex and 2 of the 3 source vertex plus the 4th point as the 3 destination vertex
>
> Before this patch, you would end up having 6 points.
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130213/836c3e59/attachment.html>
More information about the kde-edu
mailing list