Review Request 108917: Let GenericAffinityTransform and GenericProjectivityTransform use Repeated Points

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108917/#review27320
-----------------------------------------------------------


kig doesn't install those header files nor a library (as far as i can see) so you should not worry about BIC

- Albert Astals Cid


On Feb. 12, 2013, 8:11 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108917/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 8:11 a.m.)
> 
> 
> Review request for KDE Edu and Christoph Feck.
> 
> 
> Description
> -------
> 
> This change is pretty trivial, but I'd like some BIC experts to check if I can commit this to 4.10. This is a year-old bug that was quite trivial to solve and I just realized that, so I wouldn't want users to wait for another major release for a fix.
> 
> 
> This addresses bug 294655.
>     http://bugs.kde.org/show_bug.cgi?id=294655
> 
> 
> Diffs
> -----
> 
>   misc/object_constructor.h fbd019c 
>   misc/special_constructors.h d60d3d7 
>   misc/special_constructors.cc 94f7d50 
> 
> Diff: http://git.reviewboard.kde.org/r/108917/diff/
> 
> 
> Testing
> -------
> 
> 1. Create 4 points
> 2. Create a line
> 3. Create a generic affinity transform that uses 3 of the 4 points as source vertex and 2 of the 3 source vertex plus the 4th point as the 3 destination vertex
> 
> Before this patch, you would end up having 6 points.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20130212/14e545c0/attachment.html>