Review Request 114692: Better Plotter2D

[Percy Camilo Triveño Aucahuasi]

> On Dec. 30, 2013, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plotter2d.cpp, line 882
> > <https://git.reviewboard.kde.org/r/114692/diff/1/?file=227426#file227426line882>
> >
> >     Why did you change that?
> >

at() can be faster than operator[](), because it never causes a deep copy to occur. 


> On Dec. 30, 2013, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plotter2d.cpp, line 1154
> > <https://git.reviewboard.kde.org/r/114692/diff/1/?file=227426#file227426line1154>
> >
> >     This changes behavior. Why?

The last one was buggy, if you see the description in the previous version it says: "FIXME:Bad solution" the one that I'm proposing is the standard behavior for zooming and I think is bug free. 


> On Dec. 30, 2013, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plottingenums.h, line 37
> > <https://git.reviewboard.kde.org/r/114692/diff/1/?file=227428#file227428line37>
> >
> >     Unrelated changes, please don't commit those brace movements

ok


- Percy Camilo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114692/#review46424
-----------------------------------------------------------


On Dec. 28, 2013, 8:09 a.m., Percy Camilo Triveño Aucahuasi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114692/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 8:09 a.m.)
> 
> 
> Review request for KDE Edu and Aleix Pol Gonzalez.
> 
> 
> Repository: analitza
> 
> 
> Description
> -------
> 
> - Fix many bugs (ticks, labels, zooming, etc,)
> - Add polar angles and polar axis.
> - Add option to draw the angles in radians, degrees and gradians.
> - Add new grid styles (some similar to KmPlot like crosses)
> - Better API to manage colors and to set render options (like drawticks, etc.)
> - Many minor fixes/improvements too.
> 
> 
> Diffs
> -----
> 
>   analitzaplot/plottingenums.h f0c4c1c 
>   analitzaplot/private/utils/mathutils.h 08630b8 
>   analitzaplot/private/utils/mathutils.cpp d44ed6d 
>   analitzagui/plotsview2d.h b08a716 
>   analitzagui/plotsview2d.cpp f66f22d 
>   analitzaplot/plotitem.h efe942c 
>   analitzaplot/plotter2d.h ac52684 
>   analitzaplot/plotter2d.cpp 48085f1 
>   analitzaplot/plotter3d.h 85c3378 
> 
> Diff: https://git.reviewboard.kde.org/r/114692/diff/
> 
> 
> Testing
> -------
> 
> All test pass, all analitzaplot demos run ok
> 
> 
> Thanks,
> 
> Percy Camilo Triveño Aucahuasi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20131231/a0745405/attachment-0001.html>