Review Request: Fix Cantor .desktop validation

[Michael Palimaka]

> On Aug. 26, 2012, 9:56 p.m., Albert Astals Cid wrote:
> > Which tool outputs that?
> > Can you point to the spec that requires what the tool is saying?
> 
> Michael Palimaka wrote:
>     The tool is 'desktop-file-validate', and here is the spec: http://standards.freedesktop.org/menu-spec/latest/apa.html
> 
> Albert Astals Cid wrote:
>     The Related Categories column lists one or more categories that are suggested to be used in conjunction with the Additional Category.
>     
>     *suggested* does not mean *required*. Does it?
> 
> Aleix Pol Gonzalez wrote:
>     It makes sense to follow the suggestions, though...
>     
>     In any case, I don't think these .desktop files were really thought through, so if somebody has an opinion on this let's follow it. When I created KAlgebra's .desktop file, I only copied this line from some other Mathematical software and I'm pretty sure something similar happened with Cantor.
> 
> Albert Astals Cid wrote:
>     Yes, and it suggests to use one or more, we are using one. So we fit into the suggestion, don't we?

With regards to related categories, the spec differentiates between "Foo;Bar" and "Foo or Bar". In this case, the spec specifies the former, requiring either both or neither the related categories.

That said, there is some debate regarding the strictness of these requirements. If you believe that (in this case) the spec should read 'Education or Science', I am happy to submit the appropriate patch for the spec.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106216/#review18058
-----------------------------------------------------------


On Aug. 26, 2012, 1:58 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106216/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 1:58 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> Cantor fails .desktop validation:
> 
> src/cantor.desktop: error: (will be fatal in the future): value "Math" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education;Science
> 
> This patch adds the missing category.
> 
> 
> Diffs
> -----
> 
>   src/cantor.desktop 2d22b91cb6c31a0133304691f5f42c71a049e5c9 
> 
> Diff: http://git.reviewboard.kde.org/r/106216/diff/
> 
> 
> Testing
> -------
> 
> Validation passes.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20120903/cc5b23e0/attachment.html>