<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106216/">http://git.reviewboard.kde.org/r/106216/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2012, 9:56 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Which tool outputs that?
Can you point to the spec that requires what the tool is saying?</pre>
</blockquote>
<p>On August 29th, 2012, 1:18 p.m., <b>Michael Palimaka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tool is 'desktop-file-validate', and here is the spec: http://standards.freedesktop.org/menu-spec/latest/apa.html</pre>
</blockquote>
<p>On August 29th, 2012, 1:20 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Related Categories column lists one or more categories that are suggested to be used in conjunction with the Additional Category.
*suggested* does not mean *required*. Does it?</pre>
</blockquote>
<p>On August 29th, 2012, 1:24 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It makes sense to follow the suggestions, though...
In any case, I don't think these .desktop files were really thought through, so if somebody has an opinion on this let's follow it. When I created KAlgebra's .desktop file, I only copied this line from some other Mathematical software and I'm pretty sure something similar happened with Cantor.</pre>
</blockquote>
<p>On August 29th, 2012, 1:31 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, and it suggests to use one or more, we are using one. So we fit into the suggestion, don't we?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With regards to related categories, the spec differentiates between "Foo;Bar" and "Foo or Bar". In this case, the spec specifies the former, requiring either both or neither the related categories.
That said, there is some debate regarding the strictness of these requirements. If you believe that (in this case) the spec should read 'Education or Science', I am happy to submit the appropriate patch for the spec.</pre>
<br />
<p>- Michael</p>
<br />
<p>On August 26th, 2012, 1:58 p.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cantor fails .desktop validation:
src/cantor.desktop: error: (will be fatal in the future): value "Math" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education;Science
This patch adds the missing category.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Validation passes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/cantor.desktop <span style="color: grey">(2d22b91cb6c31a0133304691f5f42c71a049e5c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106216/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>