Review Request: Drop unneeded linking target

Aleix Pol Gonzalez aleixpol at gmail.com
Tue Oct 2 20:49:29 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106696/#review19787
-----------------------------------------------------------

Ship it!


Great, thanks for looking into this!

Maybe I could get notifications on problems in build.kde.org? or is there an RSS?

- Aleix Pol Gonzalez


On Oct. 2, 2012, 7:58 p.m., Ben Cooksley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106696/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 7:58 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> KAlgebra does not seem to need QGLViewer in order to successfully compile - so remove it from the link targets to make it easier to build.
> 
> It seems changes somewhere (likely in latest CMake) cause the QGLVIEWER_LIBRARY variable to be set to QGLVIEWER_LIBRARY-NOTFOUND now - instead of simply blank as it previously was when nothing was found.
> 
> Removing the ${QGLVIEWER_LIBRARY} fixes the build on build.kde.org.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7cbba68 
> 
> Diff: http://git.reviewboard.kde.org/r/106696/diff/
> 
> 
> Testing
> -------
> 
> Compiles without QGLViewer available.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121002/c2858d95/attachment.html>


More information about the kde-edu mailing list