Review Request: Drop unneeded linking target

Ben Cooksley bcooksley at kde.org
Tue Oct 2 19:58:39 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106696/
-----------------------------------------------------------

Review request for KDE Edu.


Description
-------

KAlgebra does not seem to need QGLViewer in order to successfully compile - so remove it from the link targets to make it easier to build.

It seems changes somewhere (likely in latest CMake) cause the QGLVIEWER_LIBRARY variable to be set to QGLVIEWER_LIBRARY-NOTFOUND now - instead of simply blank as it previously was when nothing was found.

Removing the ${QGLVIEWER_LIBRARY} fixes the build on build.kde.org.


Diffs
-----

  src/CMakeLists.txt 7cbba68 

Diff: http://git.reviewboard.kde.org/r/106696/diff/


Testing
-------

Compiles without QGLViewer available.


Thanks,

Ben Cooksley

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121002/684c603f/attachment.html>


More information about the kde-edu mailing list