Review Request: Google Code-In Task: FIX MARBLE CODE CHECKER ISSUES

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108035/#review24277
-----------------------------------------------------------



src/lib/ExternalEditorDialog.cpp
<http://git.reviewboard.kde.org/r/108035/#comment18585>

    make sure you have the correct code formatting
    this file seems to use spaces inside (), so this would be
    split( QLatin1Char( ':' ) )
    
    Check the other occurences of QLatin1Char as well



tools/iau2kml/iau2kml.cpp
<http://git.reviewboard.kde.org/r/108035/#comment18586>

    those initializations actually don't work.
    Make it
    = QLatin1String( "o" );


- Kevin Krammer


On Dec. 30, 2012, 5:47 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108035/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 5:47 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Google Code-In Task
> 
> 
> Diffs
> -----
> 
>   src/KdeMainWindow.cpp 6bf58ac 
>   src/lib/ExternalEditorDialog.cpp f788c11 
>   src/lib/NewstuffModel.cpp 2273edc 
>   src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp c2de87f 
>   src/plugins/runner/yours/YoursRunner.cpp e36dea1 
>   tools/asc2kml/asc2kml.cpp 92d9e3f 
>   tools/iau2kml/iau2kml.cpp 3a3f7d5 
>   tools/osm-addresses/OsmParser.cpp 4c85106 
>   tools/osm-sisyphus/job.cpp 7fc26db 
>   tools/osm-sisyphus/jobqueue.cpp b179da6 
>   tools/osm-sisyphus/upload.cpp a7cc109 
>   tools/speaker-files/main.cpp 88f5eb2 
>   tools/tilecreator-srtm2/tccore.cpp 33d0d61 
>   tools/translations/merge_ts_po.cpp 989fabc 
> 
> Diff: http://git.reviewboard.kde.org/r/108035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121230/0644319f/attachment.html>