<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108035/">http://git.reviewboard.kde.org/r/108035/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108035/diff/2/?file=103171#file103171line42" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/ExternalEditorDialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ExternalEditorDialogPrivate::ExternalEditorDialogPrivate() :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">dir</span><span class="p">,</span> <span class="n">path</span><span class="p">.</span><span class="n">split</span><span class="p">(</span><span class="hl"> </span><span class="s"><span class="hl">":"</span></span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">foreach</span><span class="p">(</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">dir</span><span class="p">,</span> <span class="n">path</span><span class="p">.</span><span class="n">split</span><span class="p">(</span><span class="n"><span class="hl">QLatin1Char</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="sc"><span class="hl">':'</span></span><span class="p"><span class="hl">)</span></span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make sure you have the correct code formatting
this file seems to use spaces inside (), so this would be
split( QLatin1Char( ':' ) )
Check the other occurences of QLatin1Char as well</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108035/diff/2/?file=103176#file103176line115" style="color: black; font-weight: bold; text-decoration: underline;">tools/iau2kml/iau2kml.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main(int argc, char *argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">115</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">marbleRoleString</span> <span class="o">=</span> <span class="s"><span class="hl">"o"</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">115</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">marbleRoleString</span> <span class="o">=</span> <span class="sc"><span class="hl">'o'</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">those initializations actually don't work.
Make it
= QLatin1String( "o" );</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On December 30th, 2012, 5:47 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 5:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Google Code-In Task</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KdeMainWindow.cpp <span style="color: grey">(6bf58ac)</span></li>
<li>src/lib/ExternalEditorDialog.cpp <span style="color: grey">(f788c11)</span></li>
<li>src/lib/NewstuffModel.cpp <span style="color: grey">(2273edc)</span></li>
<li>src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(c2de87f)</span></li>
<li>src/plugins/runner/yours/YoursRunner.cpp <span style="color: grey">(e36dea1)</span></li>
<li>tools/asc2kml/asc2kml.cpp <span style="color: grey">(92d9e3f)</span></li>
<li>tools/iau2kml/iau2kml.cpp <span style="color: grey">(3a3f7d5)</span></li>
<li>tools/osm-addresses/OsmParser.cpp <span style="color: grey">(4c85106)</span></li>
<li>tools/osm-sisyphus/job.cpp <span style="color: grey">(7fc26db)</span></li>
<li>tools/osm-sisyphus/jobqueue.cpp <span style="color: grey">(b179da6)</span></li>
<li>tools/osm-sisyphus/upload.cpp <span style="color: grey">(a7cc109)</span></li>
<li>tools/speaker-files/main.cpp <span style="color: grey">(88f5eb2)</span></li>
<li>tools/tilecreator-srtm2/tccore.cpp <span style="color: grey">(33d0d61)</span></li>
<li>tools/translations/merge_ts_po.cpp <span style="color: grey">(989fabc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108035/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>