Review Request: Fixing Krazy issues reported for Marble

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108010/#review24193
-----------------------------------------------------------



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/108010/#comment18541>

    a better way to fix this is to use QString::arg()
    
    setWindowTitle( tr("Cache Details for %1).arg( id() ) );



src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp
<http://git.reviewboard.kde.org/r/108010/#comment18542>

    no, remove gets only the first argument, no need for the empty string anymore


- Kevin Krammer


On Dec. 29, 2012, 5:24 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108010/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 5:24 p.m.)
> 
> 
> Review request for KDE Edu and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Google code-in Task
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQtMobility.cmake 1d539e7 
>   src/plugins/designer/navigator/CMakeLists.txt 86bf9e5 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp 2e0e8c8 
>   src/plugins/render/opencachingcom/OpenCachingComModel.cpp 9bc2e70 
>   src/plugins/render/overviewmap/OverviewMap.cpp 11b2c43 
>   src/plugins/render/satellites/SatellitesPlugin.cpp 7344f1b 
>   src/plugins/render/stars/StarsPlugin.cpp 91fabd5 
>   src/plugins/runner/gosmore-routing/GosmoreRoutingRunner.cpp 49b7da4 
>   src/plugins/runner/local-osm-search/DatabaseQuery.cpp 7dc47d2 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp 2a84de2 
>   src/plugins/runner/mapquest/MapQuestRunner.cpp bb33e08 
>   src/plugins/runner/monav/MonavConfigWidget.cpp 8802208 
>   src/plugins/runner/monav/MonavPlugin.cpp 150bff5 
>   src/plugins/runner/monav/MonavRunner.cpp 739a316 
>   src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp cc50b90 
>   src/plugins/runner/open-source-routing-machine/OSRMRunner.cpp 59b0c0e 
>   src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp d972b64 
>   src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp f62ce35 
>   src/plugins/runner/routino/RoutinoRunner.cpp 850f1cc 
>   src/plugins/runner/traveling-salesman/TravelingSalesmanRunner.cpp f3c0a82 
>   src/plugins/runner/yours/YoursRunner.cpp 7722f09 
>   src/qt-components/CMakeLists.txt 6557ff0 
> 
> Diff: http://git.reviewboard.kde.org/r/108010/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20121229/d8109063/attachment.html>