<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108010/">http://git.reviewboard.kde.org/r/108010/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108010/diff/1/?file=102810#file102810line92" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/opencachingcom/OpenCachingComItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void OpenCachingComItem::showInfoDialog()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dialog</span><span class="p">.</span><span class="n">setWindowTitle</span><span class="p">(</span> <span class="n">tr</span><span class="p">(</span><span class="s">"Cache Details for"</span><span class="p">)</span> <span class="o">+</span> <span class="s"><span class="hl">" "</span></span> <span class="o">+</span> <span class="n">id</span><span class="p">()</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dialog</span><span class="p">.</span><span class="n">setWindowTitle</span><span class="p">(</span> <span class="n">tr</span><span class="p">(</span><span class="s">"Cache Details for"</span><span class="p">)</span> <span class="o">+</span> <span class="sc"><span class="hl">' '</span></span> <span class="o">+</span> <span class="n">id</span><span class="p">()</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a better way to fix this is to use QString::arg()
setWindowTitle( tr("Cache Details for %1).arg( id() ) );</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108010/diff/1/?file=102824#file102824line371" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">RoutingInstruction::TurnType OpenRouteServiceRunner::parseTurnType( const QString &text, QString *road ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">371</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">*</span><span class="n">road</span> <span class="o">=</span> <span class="n">syntax</span><span class="p">.</span><span class="n">cap</span><span class="p">(</span> <span class="mi">4</span> <span class="p">).</span><span class="n">re<span class="hl">place</span></span><span class="p">(</span> <span class="s">" - Arrived at destination!"</span><span class="p">,</span> <span class="s">""</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">371</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">*</span><span class="n">road</span> <span class="o">=</span> <span class="n">syntax</span><span class="p">.</span><span class="n">cap</span><span class="p">(</span> <span class="mi">4</span> <span class="p">).</span><span class="n">re<span class="hl">move</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span> <span class="s">" - Arrived at destination!"</span><span class="p">,</span> <span class="s">""</span> <span class="p">)<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, remove gets only the first argument, no need for the empty string anymore</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On December 29th, 2012, 5:24 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Kevin Krammer.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2012, 5:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Google code-in Task</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQtMobility.cmake <span style="color: grey">(1d539e7)</span></li>
<li>src/plugins/designer/navigator/CMakeLists.txt <span style="color: grey">(86bf9e5)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.cpp <span style="color: grey">(2e0e8c8)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.cpp <span style="color: grey">(9bc2e70)</span></li>
<li>src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(11b2c43)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(7344f1b)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(91fabd5)</span></li>
<li>src/plugins/runner/gosmore-routing/GosmoreRoutingRunner.cpp <span style="color: grey">(49b7da4)</span></li>
<li>src/plugins/runner/local-osm-search/DatabaseQuery.cpp <span style="color: grey">(7dc47d2)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp <span style="color: grey">(2a84de2)</span></li>
<li>src/plugins/runner/mapquest/MapQuestRunner.cpp <span style="color: grey">(bb33e08)</span></li>
<li>src/plugins/runner/monav/MonavConfigWidget.cpp <span style="color: grey">(8802208)</span></li>
<li>src/plugins/runner/monav/MonavPlugin.cpp <span style="color: grey">(150bff5)</span></li>
<li>src/plugins/runner/monav/MonavRunner.cpp <span style="color: grey">(739a316)</span></li>
<li>src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp <span style="color: grey">(cc50b90)</span></li>
<li>src/plugins/runner/open-source-routing-machine/OSRMRunner.cpp <span style="color: grey">(59b0c0e)</span></li>
<li>src/plugins/runner/openrouteservice/OpenRouteServiceRunner.cpp <span style="color: grey">(d972b64)</span></li>
<li>src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp <span style="color: grey">(f62ce35)</span></li>
<li>src/plugins/runner/routino/RoutinoRunner.cpp <span style="color: grey">(850f1cc)</span></li>
<li>src/plugins/runner/traveling-salesman/TravelingSalesmanRunner.cpp <span style="color: grey">(f3c0a82)</span></li>
<li>src/plugins/runner/yours/YoursRunner.cpp <span style="color: grey">(7722f09)</span></li>
<li>src/qt-components/CMakeLists.txt <span style="color: grey">(6557ff0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108010/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>