Review Request: Avoid processing parameters if the number of arguments is not met in Text Labels

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102725/
-----------------------------------------------------------

(Updated Sept. 29, 2011, 4 a.m.)


Review request for KDE Edu.


Changes
-------

After testing the patch without renaming the accept slot I realized the naming was actually doing the fix, so I had to pretty much redo the whole patch. This version achieves the same (blocking acceptance of the dialog until the arguments are all set).


Description
-------

Changed the finished variable to finish, as I think is the way the code was intended to be. Also fixes the second validation that took place (calling canFinish in the finishPressed method) since first validation happens in the validatePage method of the Arguments page.


This addresses bug 282913.
    http://bugs.kde.org/show_bug.cgi?id=282913


Diffs (updated)
-----

  modes/label.cc d0c855d 
  modes/textlabelwizard.cc 0721227 

Diff: http://git.reviewboard.kde.org/r/102725/diff/diff


Testing
-------

1) Created a new label
2) Introduced a parameter %1
3) Clicked Next
4) Clicked Finish without specifying a parameter
5) Clicked Ok in the error popup

No crash, no second validation.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110929/d615a88e/attachment.html>