Review Request: KBruch - Bug 192707

[Luis Angel Fernandez Fernandez]

> On Sept. 12, 2011, 4:30 p.m., Albert Astals Cid wrote:
> > src/exercisefactorize.cpp, line 490
> > <http://git.reviewboard.kde.org/r/102582/diff/2/?file=35955#file35955line490>
> >
> >     is this a intended change?

Yes, it was. Because I thought I needed it that way. But it works using the previous version so I've undone the change. But there is an "issue" this way. When the edit is edited directly not using spaces before and/or after the 'x' if the factors buttons are used then the edit's content is rearranged putting spaces before and after the 'x'. Is that wrong or could it be kept that way?


> On Sept. 12, 2011, 4:30 p.m., Albert Astals Cid wrote:
> > src/PrimeFactorsLineEdit.cpp, line 46
> > <http://git.reviewboard.kde.org/r/102582/diff/2/?file=35953#file35953line46>
> >
> >     You are leaking the palette, just declare it on the stack, i.e. no need to new it here.

Sorry for that.


- Luis Angel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102582/#review6445
-----------------------------------------------------------


On Sept. 12, 2011, 3:23 p.m., Luis Angel Fernandez Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102582/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 3:23 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> This is my first contribution so, please, tell me if I did anything wrong. This patch is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I hope I extracted it rightly) the direct editing is working.
> 
> As I said this is my first submitting so, please, don't hesitate to ask me anything you want/need about this patch.
> 
> 
> This addresses bug 192707.
>     http://bugs.kde.org/show_bug.cgi?id=192707
> 
> 
> Diffs
> -----
> 
>   src/PrimeFactorsLineEdit.h 5e78082 
>   src/PrimeFactorsLineEdit.cpp b71bfba 
>   src/exercisefactorize.h c7d304f 
>   src/exercisefactorize.cpp 48c8874 
> 
> Diff: http://git.reviewboard.kde.org/r/102582/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis Angel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110912/d1140841/attachment.html>