Review Request: KBruch - Bug 192707

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102582/#review6445
-----------------------------------------------------------



src/PrimeFactorsLineEdit.h
<http://git.reviewboard.kde.org/r/102582/#comment5714>

    There's still some unwanted whitespaces (marked with red in reviewboard diff)



src/PrimeFactorsLineEdit.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5715>

    You do not need QObject:: since you are already a QObject



src/PrimeFactorsLineEdit.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5716>

    You are leaking the palette, just declare it on the stack, i.e. no need to new it here.



src/PrimeFactorsLineEdit.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5717>

    Remove the this-> 



src/PrimeFactorsLineEdit.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5718>

    declare the QString in the foreach



src/exercisefactorize.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5719>

    You leak the palette here again, just declare it on the stack



src/exercisefactorize.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5720>

    is this a intended change?



src/exercisefactorize.cpp
<http://git.reviewboard.kde.org/r/102582/#comment5721>

    declare the qstring in the foreach


- Albert


On Sept. 12, 2011, 3:23 p.m., Luis Angel Fernandez Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102582/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 3:23 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> This is my first contribution so, please, tell me if I did anything wrong. This patch is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I hope I extracted it rightly) the direct editing is working.
> 
> As I said this is my first submitting so, please, don't hesitate to ask me anything you want/need about this patch.
> 
> 
> This addresses bug 192707.
>     http://bugs.kde.org/show_bug.cgi?id=192707
> 
> 
> Diffs
> -----
> 
>   src/PrimeFactorsLineEdit.h 5e78082 
>   src/PrimeFactorsLineEdit.cpp b71bfba 
>   src/exercisefactorize.h c7d304f 
>   src/exercisefactorize.cpp 48c8874 
> 
> Diff: http://git.reviewboard.kde.org/r/102582/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luis Angel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110912/a138306d/attachment-0001.html>