Review Request: Enable Shortcuts + Toolbar configuration in KmPlot

[Burkhard Lück]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101927/
-----------------------------------------------------------

(Updated Sept. 5, 2011, 1:40 p.m.)


Review request for KDE Edu, Anne-Marie Mahfouf and Christoph Feck.


Changes
-------

This patch consists of three parts:
1) suggested patch for rc files by Albert
2) suggested patch for kmplot.cpp+kmplot.h by Albert
3) patch for maindlg.h/maindlg.cpp/org.kde.kmplot.KmPlot.xml
   which removes every code related to optionsConfigureKeys()
   +optionsConfigureToolbars() to make it build

In KmPlot Configure Toolbars (all actions from both toolbars) 
+ Configure Shortcuts (all actions from KmPlot/KmPlotPart, 
no duplicates any more) works.

Using KmPlotPart in Konqueror only the actions from KmPlotPart
can be changed, as expected.

Works - bugs fixed :)

Many thanks to Albert for his help!


Summary
-------

Since around kde 4.1/4.2 selecting the menu items Settings->Configure Shortcuts and Settings->Configure Toolbars do not launch both configuration dialogs any more. So it is impossible now to change shortcuts and toolbar items in kmplot.

With this patch the toolbars dialog with both toolbars is opened and the items can be changed. The shortcuts dialog opens as well, but not all actions/shortcuts are listed, only New, Open, Quit, Full Screen Mode, Handbook, WhatsThis, About KDE, About KmPlot, Configure Shortcuts, Configure Toolbars, Report Bug, Show Statusbar and Switch Languages.
All other actions/shortcuts can only be configured using kmplot_part_readonly in konqueror.
That is the same behavior as in kde 3.9.

I don't understand all the magic behind shell/parts + menu/actions merging so I can not fix the missing actions in the shortcuts dialog.

Strange is that kmplot has 3 rc files (kmplot_shell.rc, kmplot_part.rc and kmplot_part_readonly.rc) whereas e.g okular/konsole (also usable as kparts in konqueror) have only two rc files.


This addresses bugs 177014 and 268445.
    http://bugs.kde.org/show_bug.cgi?id=177014
    http://bugs.kde.org/show_bug.cgi?id=268445


Diffs (updated)
-----

  kmplot/kmplot.h df77341 
  kmplot/kmplot.cpp 239b19c 
  kmplot/kmplot_part.rc fc64866 
  kmplot/kmplot_part_readonly.rc 8d83ec9 
  kmplot/kmplot_shell.rc 8c0824f 
  kmplot/maindlg.h 1f85ade 
  kmplot/maindlg.cpp 2375e64 
  kmplot/org.kde.kmplot.KmPlot.xml e7983db 

Diff: http://git.reviewboard.kde.org/r/101927/diff


Testing
-------

Works for me as described above.


Thanks,

Burkhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20110905/36e63414/attachment.html>