<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101927/">http://git.reviewboard.kde.org/r/101927/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Anne-Marie Mahfouf and Christoph Feck.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2011, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch consists of three parts:
1) suggested patch for rc files by Albert
2) suggested patch for kmplot.cpp+kmplot.h by Albert
3) patch for maindlg.h/maindlg.cpp/org.kde.kmplot.KmPlot.xml
which removes every code related to optionsConfigureKeys()
+optionsConfigureToolbars() to make it build
In KmPlot Configure Toolbars (all actions from both toolbars)
+ Configure Shortcuts (all actions from KmPlot/KmPlotPart,
no duplicates any more) works.
Using KmPlotPart in Konqueror only the actions from KmPlotPart
can be changed, as expected.
Works - bugs fixed :)
Many thanks to Albert for his help!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since around kde 4.1/4.2 selecting the menu items Settings->Configure Shortcuts and Settings->Configure Toolbars do not launch both configuration dialogs any more. So it is impossible now to change shortcuts and toolbar items in kmplot.
With this patch the toolbars dialog with both toolbars is opened and the items can be changed. The shortcuts dialog opens as well, but not all actions/shortcuts are listed, only New, Open, Quit, Full Screen Mode, Handbook, WhatsThis, About KDE, About KmPlot, Configure Shortcuts, Configure Toolbars, Report Bug, Show Statusbar and Switch Languages.
All other actions/shortcuts can only be configured using kmplot_part_readonly in konqueror.
That is the same behavior as in kde 3.9.
I don't understand all the magic behind shell/parts + menu/actions merging so I can not fix the missing actions in the shortcuts dialog.
Strange is that kmplot has 3 rc files (kmplot_shell.rc, kmplot_part.rc and kmplot_part_readonly.rc) whereas e.g okular/konsole (also usable as kparts in konqueror) have only two rc files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for me as described above.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=177014">177014</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=268445">268445</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmplot/kmplot.h <span style="color: grey">(df77341)</span></li>
<li>kmplot/kmplot.cpp <span style="color: grey">(239b19c)</span></li>
<li>kmplot/kmplot_part.rc <span style="color: grey">(fc64866)</span></li>
<li>kmplot/kmplot_part_readonly.rc <span style="color: grey">(8d83ec9)</span></li>
<li>kmplot/kmplot_shell.rc <span style="color: grey">(8c0824f)</span></li>
<li>kmplot/maindlg.h <span style="color: grey">(1f85ade)</span></li>
<li>kmplot/maindlg.cpp <span style="color: grey">(2375e64)</span></li>
<li>kmplot/org.kde.kmplot.KmPlot.xml <span style="color: grey">(e7983db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>