Review Request: Enable Shortcuts + Toolbar configuration in KmPlot

[Anne-Marie Mahfouf]

Hi,

I am sorry but I don't have time to test as my kids are on summer holiday. I 
won't be at Desktop Summit and won't be operational again for KDE until end of 
August. I can read and answer mail but no laptop internet connection.

Best regards,

Anne-Marie

Le Tue July 12 2011 11:34:56, Burkhard Lück a écrit :
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101927/
> -----------------------------------------------------------
> 
> (Updated July 12, 2011, 9:34 a.m.)
> 
> 
> Review request for KDE Edu, Anne-Marie Mahfouf and Christoph Feck.
> 
> 
> Changes
> -------
> 
> adding the kdeedu coordinator
> 
> 
> Summary
> -------
> 
> Since around kde 4.1/4.2 selecting the menu items Settings->Configure
> Shortcuts and Settings->Configure Toolbars do not launch both
> configuration dialogs any more. So it is impossible now to change
> shortcuts and toolbar items in kmplot.
> 
> With this patch the toolbars dialog with both toolbars is opened and the
> items can be changed. The shortcuts dialog opens as well, but not all
> actions/shortcuts are listed, only New, Open, Quit, Full Screen Mode,
> Handbook, WhatsThis, About KDE, About KmPlot, Configure Shortcuts,
> Configure Toolbars, Report Bug, Show Statusbar and Switch Languages. All
> other actions/shortcuts can only be configured using kmplot_part_readonly
> in konqueror. That is the same behavior as in kde 3.9.
> 
> I don't understand all the magic behind shell/parts + menu/actions merging
> so I can not fix the missing actions in the shortcuts dialog.
> 
> Strange is that kmplot has 3 rc files (kmplot_shell.rc, kmplot_part.rc and
> kmplot_part_readonly.rc) whereas e.g okular/konsole (also usable as kparts
> in konqueror) have only two rc files.
> 
> 
> This addresses bugs 177014 and 268445.
>     http://bugs.kde.org/show_bug.cgi?id=177014
>     http://bugs.kde.org/show_bug.cgi?id=268445
> 
> 
> Diffs
> -----
> 
>   kmplot/kmplot_part.rc fc64866
>   kmplot/kmplot_shell.rc 8c0824f
> 
> Diff: http://git.reviewboard.kde.org/r/101927/diff
> 
> 
> Testing
> -------
> 
> Works for me as described above.
> 
> 
> Thanks,
> 
> Burkhard