[kde-edu]: Review Request: Parley: [PATCH] Added dictation practice.

Massimo Lo Iacono massimol at lillinet.org
Wed Feb 16 00:53:18 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6489/
-----------------------------------------------------------

Review request for KDE-Edu.


Summary
-------

Hallo.
I have made the modifications to add functionality for dictation practice.

Dictation is a monolanguage type of practice. It consists a sound (only) question and a text solution in the same language of question.

The language of practice is the first of the pair languageFrom/languageTo.

For developers:

Since the dictation practice is of the type monolanguage and the pre existent code was for bilanguage practice, I modified a bit the code in order that now it is adapt also for a monolanguage type of practice.

I added these new 4 files in "src/4/kdeedu/parley/src/practice/" directory:

  dictationbackendmode.h
  dictationbackendmode.cpp
  dictationmodewidget.h
  dictationmodewidget.cpp

I can send these file as attachments in the parley develop mailing list.

IMPORTANT: to manage the visualisation of question and solution images, I was forced to create the new function:

  GuiFrontend::compareImage()

and to modify the functions:

  AbstractBackendMode::setTestEntry
  MultipleChoiceBackendMode::setTestEntry
  ConjugationBackendMode::setTestEntry
  ComparisonBackendMode::setTestEntry
  
adding the rows:

  m_frontend->setQuestionImage
  m_frontend->setSolutionImage
  m_frontend->compareImage();

I created the patch from the 1218525 revision, almost 2 weeks old.

I can successful compile and execute the code with my modifications.


Diffs
-----

  /trunk/KDE/kdeedu/CMakeLists.txt 1218525 
  /trunk/KDE/kdeedu/parley/src/CMakeLists.txt 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/abstractbackendmode.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/guifrontend.h 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h 1218525 
  /trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/settings/parley.kcfg 1218525 
  /trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp 1218525 
  /trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.ui 1218525 

Diff: http://svn.reviewboard.kde.org/r/6489/diff


Testing
-------

I can successful compile and execute the code with my modifications.


Thanks,

Massimo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110215/da358174/attachment.htm 


More information about the kde-edu mailing list