Review Request: Add conjunction to the (default) word types

Frederik Gladhorn gladhorn at kde.org
Fri Dec 30 09:04:09 UTC 2011


Mandag 28. november 2011 21.44.23 skrev Jan Gerrit Marker:
> > On Nov. 23, 2011, 2:09 p.m., Frederik Gladhorn wrote:
> > > Looks great. Please commit.
> 
> Sorry for the delay.
> The commit would add a new string, is this allowed for Parley currently? I
> don't know whether it sticks to KDE's freezes.

Yes, Parley is released with all the big parts of KDE. Therfor the schedule on 
techbase applies.

Cheers
Frederik



> 
> 
> - Jan Gerrit
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103192/#review8412
> -----------------------------------------------------------
> 
> On Nov. 22, 2011, 4:41 p.m., Jan Gerrit Marker wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/103192/
> > -----------------------------------------------------------
> > 
> > (Updated Nov. 22, 2011, 4:41 p.m.)
> > 
> > 
> > Review request for KDE Edu.
> > 
> > 
> > Description
> > -------
> > 
> > This patch does two things:
> > * Adds conjunction to the list of special word types in the context menu
> > of the word type view * Adds conjunction to the default list of word
> > types when creating a new file
> > 
> > I would commit them separately, but the patches are that small that I
> > did load them up together.
> > 
> > Update:
> > In order to save and load the word type correctly the patch which is
> > posted at https://git.reviewboard.kde.org/r/103204/ is needed.
> > 
> > 
> > Diffs
> > -----
> > 
> >   src/parleydocument.cpp 047b703
> >   src/vocabulary/wordtypeview.h 24b8a2c
> >   src/vocabulary/wordtypeview.cpp 1d399b6
> > 
> > Diff: http://git.reviewboard.kde.org/r/103192/diff/diff
> > 
> > 
> > Testing
> > -------
> > 
> > Works for me.
> > 
> > 
> > Thanks,
> > 
> > Jan Gerrit Marker


More information about the kde-edu mailing list