Review Request: Add conjunction to the (default) word types

[Albert Astals Cid]

> On Nov. 23, 2011, 2:09 p.m., Frederik Gladhorn wrote:
> > Looks great. Please commit.
> 
> Jan Gerrit Marker wrote:
>     Sorry for the delay.
>     The commit would add a new string, is this allowed for Parley currently? I don't know whether it sticks to KDE's freezes.
> 
> Albert Astals Cid wrote:
>     This looks like a new feature, no, we do not allow new features at the moment (nor new strings either), see http://techbase.kde.org/Schedules/KDE4/4.8_Release_Schedule
> 
> Jan Gerrit Marker wrote:
>     Okay, thank you for the clarification. I will push it after 4.8 is branched.

4.8 has already been branched


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103192/#review8412
-----------------------------------------------------------


On Nov. 22, 2011, 4:41 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103192/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2011, 4:41 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This patch does two things:
> * Adds conjunction to the list of special word types in the context menu of the word type view
> * Adds conjunction to the default list of word types when creating a new file
> 
> I would commit them separately, but the patches are that small that I did load them up together.
> 
> Update:
> In order to save and load the word type correctly the patch which is posted at https://git.reviewboard.kde.org/r/103204/ is needed.
> 
> 
> Diffs
> -----
> 
>   src/parleydocument.cpp 047b703 
>   src/vocabulary/wordtypeview.h 24b8a2c 
>   src/vocabulary/wordtypeview.cpp 1d399b6 
> 
> Diff: http://git.reviewboard.kde.org/r/103192/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Jan Gerrit Marker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20111228/71080f26/attachment-0001.html>