[kde-edu]: Re: Review Request: KTouch: Fix for "clear history" bug

[Anne-Marie Mahfouf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101078/#review2572
-----------------------------------------------------------

Ship it!


I checked it and it works as expected! Do you want a git account so you can push this yourself and carry on fixing KTouch?

- Anne-Marie


On April 10, 2011, 8:49 p.m., Peter Rüthemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101078/
> -----------------------------------------------------------
> 
> (Updated April 10, 2011, 8:49 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Summary
> -------
> 
> Because ktouch finally moved to git, I publish my bug fix again.
> 
> I fixed a bug in KTouch. At the moment it's not possible to clear the statistics in the "training statistics" window. Only a part of the statistics was cleared. 
> 
> Changelog:
> - The fix clears the current statistics and refreshes the UI
> - The sessions restarts at the current level
> - The clearStatistics function has now a parameter. The parameter decides whether a new session should be started or not.
> 
> I really like git and kdeedu, so I hope I can contribute a little bit.
> 
> Peter
> 
> 
> This addresses bug 149758.
>     http://bugs.kde.org/show_bug.cgi?id=149758
> 
> 
> Diffs
> -----
> 
>   src/ktouch.h 3744e72 
>   src/ktouch.cpp 55bab64 
>   src/ktouchstatisticsdialog.cpp 64faa43 
> 
> Diff: http://git.reviewboard.kde.org/r/101078/diff
> 
> 
> Testing
> -------
> 
> Fix works with compiled KTouch.
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20110412/cfeb3143/attachment.htm