[kde-edu]: Review Request: krazy fixes: kdeedu kmplot: single-char QString operations

[Pieter Vande Wyngaerde]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3333/
-----------------------------------------------------------

Review request for KDE-Edu.


Summary
-------

krazy2 Analysis:
Check single-char QString operations for efficiency [doublequote_chars]...OOPS! 11 issues found!

    * kmplot/xparser.cpp: line# 272,274,276 (3)
    * kmplot/functioneditor.cpp: line# 471,490,491,504 (4)
    * kmplot/function.cpp: line# 48 (1)
    * kmplot/view.cpp: line# 798,800 (2)
    * kmplot/initialconditionseditor.cpp: line# 156 (1)

(this is my first try)


Diffs
-----

  trunk/KDE/kdeedu/kmplot/kmplot/function.cpp 1105921 
  trunk/KDE/kdeedu/kmplot/kmplot/functioneditor.cpp 1105921 
  trunk/KDE/kdeedu/kmplot/kmplot/initialconditionseditor.cpp 1105921 
  trunk/KDE/kdeedu/kmplot/kmplot/view.cpp 1105921 
  trunk/KDE/kdeedu/kmplot/kmplot/xparser.cpp 1105921 

Diff: http://reviewboard.kde.org/r/3333/diff


Testing
-------

none


Thanks,

Pieter