[kde-edu]: Review Request: Molmasscalcuation for the kalzium-engine

[etienne.rebetez at oberwallis.ch]

> On 2010-03-10 16:20:48, Carsten Niehaus wrote:
> > Looks good to me. Thanks for taking care!

I'am glad it's ok:) 
Just an other question, do i have to do somthing additional to get it in trunk? I just noticed that some newer "Ship it" code is alredy in trunk.


- eti


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3228/#review4454
-----------------------------------------------------------


On 2010-03-09 19:11:33, eti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3228/
> -----------------------------------------------------------
> 
> (Updated 2010-03-09 19:11:33)
> 
> 
> Review request for KDE-Edu and Plasma.
> 
> 
> Summary
> -------
> 
> I was playing with plasma and made a little plasmoid on kde-look: http://kde-look.org/content/show.php?content=114429
> The dataengine used is derived from the kalzium dataengine, so i thought i could put the molmass-caculation-code in the "real" kalzium-engine.
>  
> new features:
> - Send a Molecule to the Engine and get 
>   - the total molecular mass
>   - a string with the summerized Elements. e.g CH3CH2OH > C2H6O
> - Added some Element informations, like electronegativity and electronconfiguration.
> 
> The new molecule query is "Molecule:Parser:<SomeMolecule>"
> 
> Thanks for feedbacks
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kalzium/plasmoid/engine/kalzium_engine.h 1101250 
>   /trunk/KDE/kdeedu/kalzium/plasmoid/engine/kalzium_engine.cpp 1101250 
> 
> Diff: http://reviewboard.kde.org/r/3228/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> eti
> 
>