[kde-edu]: Review Request: GetHotNewStuff3 for Marble

jensmh at gmx.de jensmh at gmx.de
Fri Mar 5 15:02:12 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3085/#review4389
-----------------------------------------------------------


Hi,

first, thanks you for your contribution.
Unfortunately we got a very similar patch submitted three weeks ago (marble-devel mailing list, 16.02.2010).
The reason why it is still not committed is that it would trigger the krazy code checker to
report an issue (for details, see http://www.kdedevelopers.org/node/3919).
The same would apply to this patch.
So, I'm sorry that work was duplicated here, but for obvious reasons I'd like to commit
the first patch we got (once that is fixed).


Kind regards,

Jens-Michael

- jmho


On 2010-03-02 18:34:33, eti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3085/
> -----------------------------------------------------------
> 
> (Updated 2010-03-02 18:34:33)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> Just ported Mable to Get hot new stuff 3. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/CMakeLists.txt 1098019 
>   trunk/KDE/kdeedu/marble/src/marble.knsrc 1098019 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1098019 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1098019 
> 
> Diff: http://reviewboard.kde.org/r/3085/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> eti
> 
>



More information about the kde-edu mailing list