[kde-edu]: Review Request: GetHotNewStuff3 for Marble

Frederik Gladhorn gladhorn at kde.org
Fri Mar 5 14:10:21 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3085/#review4388
-----------------------------------------------------------

Ship it!


Apart from the forward declaration, I think this looks good.

- Frederik


On 2010-03-02 18:34:33, eti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3085/
> -----------------------------------------------------------
> 
> (Updated 2010-03-02 18:34:33)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> Just ported Mable to Get hot new stuff 3. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/CMakeLists.txt 1098019 
>   trunk/KDE/kdeedu/marble/src/marble.knsrc 1098019 
>   trunk/KDE/kdeedu/marble/src/marble_part.h 1098019 
>   trunk/KDE/kdeedu/marble/src/marble_part.cpp 1098019 
> 
> Diff: http://reviewboard.kde.org/r/3085/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> eti
> 
>



More information about the kde-edu mailing list