[kde-edu]: Review Request: [kalzium] new Periodsystem engine

[Carsten Niehaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4219/#review6005
-----------------------------------------------------------

Ship it!


I had a closes look and like it.

Only comment: I don't like the include-name "pstable", I always read "p stable" instead of "ps table". Perhaps psetable.h would be a better name.

- Carsten


On 2010-06-03 19:09:41, eti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4219/
> -----------------------------------------------------------
> 
> (Updated 2010-06-03 19:09:41)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> Hi all
> 
> The kalziumTableType class has a good idea. It just is to kalzium specific so i rewrote it to be universal.
> 
> The new class has no other dependencys than Qt.
> In that patch Kalzium is alredy ported to the new class.
> 
> I put the class in the science library. Is that ok?
> 
> 
> Thanks for comments.
> 
> Etienne
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/kalzium/src/kalziumtabletype.h 1134247 
>   /trunk/KDE/kdeedu/kalzium/src/kalziumtabletype.cpp 1134247 
>   /trunk/KDE/kdeedu/libkdeedu/libscience/CMakeLists.txt 1134248 
>   /trunk/KDE/kdeedu/libkdeedu/libscience/pstables.h PRE-CREATION 
>   /trunk/KDE/kdeedu/libkdeedu/libscience/pstables.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4219/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> eti
> 
>