[kde-edu]: Review Request: [kalzium] new Periodsystem engine
etienne.rebetez at oberwallis.ch
etienne.rebetez at oberwallis.ch
Thu Jun 3 21:09:41 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4219/
-----------------------------------------------------------
Review request for KDE-Edu.
Summary
-------
Hi all
The kalziumTableType class has a good idea. It just is to kalzium specific so i rewrote it to be universal.
The new class has no other dependencys than Qt.
In that patch Kalzium is alredy ported to the new class.
I put the class in the science library. Is that ok?
Thanks for comments.
Etienne
Diffs
-----
/trunk/KDE/kdeedu/kalzium/src/kalziumtabletype.h 1134247
/trunk/KDE/kdeedu/kalzium/src/kalziumtabletype.cpp 1134247
/trunk/KDE/kdeedu/libkdeedu/libscience/CMakeLists.txt 1134248
/trunk/KDE/kdeedu/libkdeedu/libscience/pstables.h PRE-CREATION
/trunk/KDE/kdeedu/libkdeedu/libscience/pstables.cpp PRE-CREATION
Diff: http://reviewboard.kde.org/r/4219/diff
Testing
-------
Thanks,
eti
More information about the kde-edu
mailing list