[kde-edu]: Re: Review Request: Marble: config dialog for map scale plugin + scale ratio implemented

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6153/#review9308
-----------------------------------------------------------

Ship it!


Excellent. Apart from the minor comment below it would be great if you could add "marble" to the Groups section of this review request (in addition to kdeedu). I'll mark this task as done.


/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp
<http://svn.reviewboard.kde.org/r/6153/#comment10253>

    you can use qRound for this kind of stuff :)


- Torsten


On 2010-12-19 08:09:43, Khanh-Nhan Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6153/
> -----------------------------------------------------------
> 
> (Updated 2010-12-19 08:09:43)
> 
> 
> Review request for KDE-Edu.
> 
> 
> Summary
> -------
> 
> - Config dialog for map scale plugin (with a single option visible/invisible).
> - Scale ratio implemented and displayed below the scale bar (with an acceptable error).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/global.h 1207419 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/CMakeLists.txt 1207419 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleConfigWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.h 1207419 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp 1207419 
> 
> Diff: http://svn.reviewboard.kde.org/r/6153/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Config dialog
>   http://svn.reviewboard.kde.org/r/6153/s/584/
> After uncheck the box in the config dialog - scale bar becomes invisible
>   http://svn.reviewboard.kde.org/r/6153/s/585/
> the config box & the ratio scale
>   http://svn.reviewboard.kde.org/r/6153/s/586/
> After unchecking the box, the ratio has gone.
>   http://svn.reviewboard.kde.org/r/6153/s/587/
> 
> 
> Thanks,
> 
> Khanh-Nhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-edu/attachments/20101219/277c8b1a/attachment.htm