<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6153/">http://svn.reviewboard.kde.org/r/6153/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Excellent. Apart from the minor comment below it would be great if you could add "marble" to the Groups section of this review request (in addition to kdeedu). I'll mark this task as done.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/6153/diff/3/?file=42707#file42707line164" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MapScaleFloatItem::paintContent( GeoPainter *painter,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">iRatio</span> <span class="o">=</span> <span class="p">(</span><span class="kt">int</span><span class="p">)(</span><span class="n">ratio</span> <span class="o">+</span> <span class="mf">0.5</span><span class="p">);</span> <span class="c1">//round ratio to the nearest integer</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can use qRound for this kind of stuff :)</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On December 19th, 2010, 8:09 a.m., Khanh-Nhan Nguyen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Khanh-Nhan Nguyen.</div>
<p style="color: grey;"><i>Updated 2010-12-19 08:09:43</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Config dialog for map scale plugin (with a single option visible/invisible).
- Scale ratio implemented and displayed below the scale bar (with an acceptable error).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/global.h <span style="color: grey">(1207419)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/CMakeLists.txt <span style="color: grey">(1207419)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleConfigWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.h <span style="color: grey">(1207419)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/mapscale/MapScaleFloatItem.cpp <span style="color: grey">(1207419)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6153/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6153/s/584/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/18/Screenshot-1_400x100.png" style="border: 1px black solid;" alt="Config dialog" /></a>
<a href="http://svn.reviewboard.kde.org/r/6153/s/585/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/18/Screenshot-2_400x100.png" style="border: 1px black solid;" alt="After uncheck the box in the config dialog - scale bar becomes invisible" /></a>
<a href="http://svn.reviewboard.kde.org/r/6153/s/586/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/19/Screenshot-3_400x100.png" style="border: 1px black solid;" alt="the config box & the ratio scale" /></a>
<a href="http://svn.reviewboard.kde.org/r/6153/s/587/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/12/19/Screenshot-4_400x100.png" style="border: 1px black solid;" alt="After unchecking the box, the ratio has gone." /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>