[kde-edu]: KTurtle patch

Benoit Jacob jacob at math.jussieu.fr
Wed Oct 3 10:45:38 CEST 2007


Hi Annma,

I confirm that <cmath> is the proper name under which c++ programs should 
include the standard math header. You do raise a good about comptibility 
with old compilers; I have no clue whether there are problems in that 
respect; all I know is that I include <cmath> in Eigen and nobody ever 
reported problems (and Eigen has been used on many different platforms).

Cheers,
Benoit

On Wed, 3 Oct 2007, Anne-Marie Mahfouf wrote:

> Le Tuesday 02 October 2007 23:46:47 Jeff Shipley, vous avez écrit :
> I have a first patch ready.  The turtle pointed up at 0 degrees and moved
> clockwise as the degrees increased.
>
> This is different from the way it should work, ie right at 0 degrees and
> move counter-clockwise.
>
> I worked this one out during a lecture at school (I probably should have
> been listening more, but...)
>
> I don't have a kde svn account yet, so I am asking the good people on this
> list to review my patch and check it in for me.
>
> Thank you,
> Jeff

Hi Jeff,

I reviewed the patch which is OK :)
The only thing I windered about was the cmath include but grepping kdelibs I 
found it used a bit versus math.h so it's OK (I was concerned about old 
compilers or non-linux systems)

I see that you have a svn account so I leave it to you to commit!

Anne-Marie

_______________________________________________
kde-edu mailing list
kde-edu at mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


More information about the kde-edu mailing list