D29006: Allow to copy or move selection to the other split view

Méven Car noreply at phabricator.kde.org
Sun May 3 11:35:28 BST 2020


meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  I tested the patch, works nicely.
  Just a check to add.
  
  Drag'n drop is quite easy in the use case it covers, so wait for @ngraham and/or @elvisangelaccio feedback before merging.

INLINE COMMENTS

> dolphinmainwindow.cpp:1993
> +            copyToOtherViewAction->setEnabled(true);
> +            moveToOtherViewAction->setEnabled(capabilities.supportsMoving());
> +        } else {

This is not sufficient, you can copy or move to `recentlyused:/files/` for instance, which fails.
So test the other view url to see if it is writable as well.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29006

To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure
Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20200503/6a12dbe1/attachment.html>


More information about the kde-doc-english mailing list