D19770: Use placeholder for search action
Nathaniel Graham
noreply at phabricator.kde.org
Sun Mar 17 21:51:20 GMT 2019
ngraham added a comment.
Now Dolphin doesn't compile:
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp: In member function ‘void DolphinMainWindow::setupActions()’:
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1145:5: error: invalid use of member function ‘void DolphinMainWindow::find()’ (did you forget the ‘()’ ?)
find->setText(i18n("Search..."));
^~~~
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1145:9: error: base operand of ‘->’ is not a pointer
find->setText(i18n("Search..."));
^~
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1144:14: warning: unused variable ‘search’ [-Wunused-variable]
QAction *search = KStandardAction::find(this, &DolphinMainWindow::find, actionCollection());
^~~~~~
Looks like that should be `search->setText(blablabla)`
Make sure you're testing your changes! :)
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D19770
To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20190317/f0d24368/attachment.html>
More information about the kde-doc-english
mailing list