<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19770">View Revision</a></tr></table><br /><div><div><p>Now Dolphin doesn't compile:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp: In member function ‘void DolphinMainWindow::setupActions()’:
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1145:5: error: invalid use of member function ‘void DolphinMainWindow::find()’ (did you forget the ‘()’ ?)
     find->setText(i18n("Search..."));
     ^~~~
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1145:9: error: base operand of ‘->’ is not a pointer
     find->setText(i18n("Search..."));
         ^~
/home/nate/kde/src/dolphin/src/dolphinmainwindow.cpp:1144:14: warning: unused variable ‘search’ [-Wunused-variable]
     QAction *search = KStandardAction::find(this, &DolphinMainWindow::find, actionCollection());
              ^~~~~~</pre></div>

<p>Looks like that should be <tt style="background: #ebebeb; font-size: 13px;">search->setText(blablabla)</tt></p>

<p>Make sure you're testing your changes! :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19770">https://phabricator.kde.org/D19770</a></div></div><br /><div><strong>To: </strong>ognarb, Dolphin, VDG, ngraham, elvisangelaccio<br /><strong>Cc: </strong>kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov<br /></div>